Properly handle missing dune-project #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
force-pushed
the
no-dune-project
branch
from
5e803ab
to
df4dc41
Compare
|
Just merged #203, can you please rebase? That will make reviewing a bit easier. |
Leonidas-from-XIV
requested changes
Nov 5, 2021
The name of the lockfile to generate depends on the target packages rather than on the local ones. This both clarifies that by renaming the labeled argument, making it mandatory and removing the unused code path where it would try to determine the local packages itself. Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
no-dune-project
branch
from
21eaa5f
to
394a3bd
Compare
Leonidas-from-XIV
approved these changes
Nov 5, 2021
emillon
reviewed
Nov 5, 2021
This moves the dune file up so it will apply to all future tests as long as turning the test into a cram folder, incuding the files to the tree rather than generating them as part of the test. `cd`ing into the folder to try running commands is now possible which should help debugging issues. We still `cat` the content of the files so that the `run.t` file is self contained and one does not have to browse files to fully understand the test. Signed-off-by: Nathan Rebours <[email protected]>
|
I moved the test to a cram folder an wrote the file to the source tree instead of generating them. I think that's a better practice for writing tests. I still
|
emillon
approved these changes
Nov 8, 2021
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Nov 23, 2021
CHANGES: ### Added - Add a list subcommand to list the duniverse packages in the lockfile (tarides/opam-monorepo#217, @samoht) ### Changed - Only warn users about missing dune-ports repo in OPAM switch if no solution can be found due to packages not building with dune (tarides/opam-monorepo#210, @Leonidas-from-XIV) - Rename the `--repo` option to `--root` to make it more straightforward that this is referring to the project root (tarides/opam-monorepo#218, @samoht) - Improve the wording of the lockfile selection log (tarides/opam-monorepo#222, @NathanReb) - Display the full solver error with `--verbose` (tarides/opam-monorepo#229, @emillon) ### Fixed - Better errors for `opam-monorepo depext`, especially for non-interactive shells (tarides/opam-monorepo#216, @samoht) - Properly detect all opam packages defined in the current repository, preventing it from later pulling duplicates into the duniverse if they were part of the target packages dependencies. (tarides/opam-monorepo#203, @Leonidas-from-XIV) - Properly report missing dune-project file when trying to determine the to-be-genrated lockfile name (tarides/opam-monorepo#227, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225 !
Depends on #203.
This PR improves the error message when a dune-project file is missing at the root. As the test shows, it now prints a nice error with suggested actions instead of an uncaught exception with a backtrace!